Chunking NG: Assemble in natural sort order of files #3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke and @nickvergessen to be potential reviewers. |
For owncloud/client#5476 Before this, the assembly could be bogusly in the order 0,1,10,11,2,3 etc. As per the spec "The name of every chunk should be its chunk number." https://github.com/cernbox/smashbox/blob/master/protocol/chunking.md Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
downstream-26995
branch
from
7488634 to
075a606
Compare
Codecov Report
@@ Coverage Diff @@
## master #3886 +/- ##
=========================================
Coverage 54.21% 54.21%
Complexity 21092 21092
=========================================
Files 1303 1303
Lines 80526 80526
Branches 1270 1270
=========================================
Hits 43657 43657
Misses 36869 36869
Continue to review full report at Codecov.
|
rullzer
approved these changes
Mar 17, 2017
nickvergessen
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For owncloud/client#5476
Before this, the assembly could be bogusly in the order 0,1,10,11,2,3 etc.
As per the spec "The name of every chunk should be its chunk number."
https://github.com/cernbox/smashbox/blob/master/protocol/chunking.md